Added hidden_attributes method for default hidden attributes. #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the advantage of doing this, when attributes are already a white list? |
|
It avoids defining a new class to display select attributes in exceptional cases. |
|
We implemented same behavior in our app a bit different: def filter(keys)
default_keys = keys - hidden_attributes
case
when @only.present?
keys & @only
when @expose.present?
default_keys + @expose
else
default_keys
end
end |
|
This is out of date, and I'm still not convinced it's worth it. Thank you! |
|
You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to define
hidden_attributesthat are not rendered by default. For example, say you have aUserSerializerwith ahome_addressattribute that you don't want to remember to exclude every time you use that serializer. Just define your serializer withhidden_attributes :home_addressand then add theexpose: :home_addressoption in the places where you do wanthome_addressdisplayed.